eSlider/go-onlyoffice
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 3 Wiki Activity

Merge pull request #36 from eSlider/fix/delete-files-dav
Release / GoReleaser (push) Skipped
Release Please / Release Please (push) Skipped
Details
Tests / Secret scan (gitleaks) (push) Failing after 4s
Details
Tests / Test (Go 1.25) (push) Successful in 1m29s
Details
Tests / Test (Go stable) (push) Successful in 1m31s
Details

Browse Source 
fix(files): DeleteFiles actually removes files on produktor OO
This commit is contained in:
eSlider
2026-08-27 23:36:19 +01:00
committed by GitHub
co-authored by GitHub
parent 2b267d36a8 622dcdb7bf
commit a8cb4e9780
1 changed files with 6 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
files.go
+6 -10
View File
@@ -263,22 +263,18 @@ func (c *Client) RenameFile(ctx context.Context, fileID, newTitle string) (*File
return decodeResponseFileEntry(raw) return decodeResponseFileEntry(raw)
} }
type deleteFilesBody struct {
FileIDs []int `json:"fileIds"`
FolderIDs []int `json:"folderIds"`
}
// DeleteFiles permanently deletes files by numeric id (Documents module). // DeleteFiles permanently deletes files by numeric id (Documents module).
// Uses per-file DELETE (DeleteDavItems); fileops/delete returns 200 on some
// portals (e.g. produktor.io) without removing the file.
func (c *Client) DeleteFiles(ctx context.Context, fileIDs []int) error { func (c *Client) DeleteFiles(ctx context.Context, fileIDs []int) error {
if len(fileIDs) == 0 { if len(fileIDs) == 0 {
return fmt.Errorf("no file ids to delete") return fmt.Errorf("no file ids to delete")
} }
body := deleteFilesBody{FileIDs: fileIDs, FolderIDs: nil} strIDs := make([]string, len(fileIDs))
_, err := c.putJSON(ctx, "/api/2.0/files/fileops/delete.json", body) for i, id := range fileIDs {
if err != nil { strIDs[i] = strconv.Itoa(id)
_, err = c.putJSON(ctx, "/api/2.0/files/fileops/delete", body)
} }
return err return c.DeleteDavItems(ctx, nil, strIDs)
} }
// ListFolder returns the Documents module listing for a folder id // ListFolder returns the Documents module listing for a folder id