2dph/internal/httpapi/server_test.go

package httpapi

import (
	"context"
	"encoding/json"
	"net/http"
	"net/http/httptest"
	"os"
	"strings"
	"sync"
	"sync/atomic"
	"testing"
	"time"
)

// fakeSearcher is an injectable Searcher for tests (no python involved).
type fakeSearcher struct {
	mu       sync.Mutex
	delay    time.Duration
	calls    int
	active   atomic.Int32
	maxSeen  atomic.Int32
	callback func(q string, limit int) ([]byte, error)
}

func (f *fakeSearcher) Search(ctx context.Context, query string, limit int) ([]byte, error) {
	f.mu.Lock()
	f.calls++
	f.mu.Unlock()
	n := f.active.Add(1)
	for {
		old := f.maxSeen.Load()
		if n <= old || f.maxSeen.CompareAndSwap(old, n) {
			break
		}
	}
	defer f.active.Add(-1)
	if f.delay > 0 {
		select {
		case <-time.After(f.delay):
		case <-ctx.Done():
			return nil, ctx.Err()
		}
	}
	if f.callback != nil {
		return f.callback(query, limit)
	}
	return []byte(`{"query":"` + query + `","count":0,"results":[]}`), nil
}

func (f *fakeSearcher) Get(_ context.Context, id string, body bool) ([]byte, error) {
	out := map[string]any{"id": id, "root": "info"}
	if body {
		out["text"] = "fake body"
	}
	return json.Marshal(out)
}

func (f *fakeSearcher) Stats(context.Context) ([]byte, error) {
	return []byte(`{"total":0,"by_root":{}}`), nil
}

func (f *fakeSearcher) Audit(context.Context) ([]byte, error) {
	return []byte(`{"status":"ok"}`), nil
}

func (f *fakeSearcher) Ingest(context.Context) ([]byte, error) {
	return []byte(`{"mode":"rebuild","command":"bin/brain/index.go --rebuild"}`), nil
}

func (f *fakeSearcher) count() int {
	f.mu.Lock()
	defer f.mu.Unlock()
	return f.calls
}

func get(t *testing.T, h http.Handler, path string) (int, []byte) {
	t.Helper()
	req := httptest.NewRequest(http.MethodGet, path, nil)
	rec := httptest.NewRecorder()
	h.ServeHTTP(rec, req)
	return rec.Code, rec.Body.Bytes()
}

func TestHealth(t *testing.T) {
	h := NewServer(&fakeSearcher{}, 1)
	code, body := get(t, h, "/health")
	if code != http.StatusOK {
		t.Fatalf("health code = %d, want 200", code)
	}
	var out map[string]any
	if err := json.Unmarshal(body, &out); err != nil {
		t.Fatalf("health body not json: %v (%s)", err, body)
	}
	if out["status"] != "ok" {
		t.Fatalf("health status = %v, want ok", out["status"])
	}
}

func TestSearchMissingQuery(t *testing.T) {
	h := NewServer(&fakeSearcher{}, 1)
	if code, _ := get(t, h, "/search"); code != http.StatusBadRequest {
		t.Fatalf("code = %d, want 400", code)
	}
}

func TestSearchReturnsSearcherResult(t *testing.T) {
	fs := &fakeSearcher{callback: func(q string, limit int) ([]byte, error) {
		return []byte(`{"query":"` + q + `","count":1,"results":[{"id":"x"}]}`), nil
	}}
	h := NewServer(fs, 1)
	code, body := get(t, h, "/search?q=matrix")
	if code != http.StatusOK {
		t.Fatalf("code = %d, want 200", code)
	}
	var out map[string]any
	if err := json.Unmarshal(body, &out); err != nil {
		t.Fatalf("body not json: %v (%s)", err, body)
	}
	if out["query"] != "matrix" {
		t.Fatalf("query = %v, want matrix", out["query"])
	}
	if fs.count() != 1 {
		t.Fatalf("searcher called %d times, want 1", fs.count())
	}
}

func TestSearchConcurrencyBounded(t *testing.T) {
	// 8 parallel requests on a 3-worker pool: at most 3 concurrent searches.
	fs := &fakeSearcher{delay: 20 * time.Millisecond}
	h := NewServer(fs, 3)

	var wg sync.WaitGroup
	for i := 0; i < 8; i++ {
		wg.Add(1)
		go func() {
			defer wg.Done()
			req := httptest.NewRequest(http.MethodGet, "/search?q=abc", nil)
			rec := httptest.NewRecorder()
			h.ServeHTTP(rec, req)
			if rec.Code != http.StatusOK {
				t.Errorf("code = %d, want 200", rec.Code)
			}
		}()
	}
	wg.Wait()

	if calls := fs.count(); calls != 8 {
		t.Fatalf("searcher called %d times, want 8", calls)
	}
	if max := fs.maxSeen.Load(); max > 3 {
		t.Fatalf("max concurrent = %d, want <= 3", max)
	}
	if max := fs.maxSeen.Load(); max < 1 {
		t.Fatalf("max concurrent = %d, want >= 1", max)
	}
}

func TestSearchRejectsBadLimit(t *testing.T) {
	h := NewServer(&fakeSearcher{}, 1)
	if code, _ := get(t, h, "/search?q=x&n=hundred"); code != http.StatusBadRequest {
		t.Fatalf("code = %d, want 400", code)
	}
}

func TestGetLeaf(t *testing.T) {
	fs := &fakeSearcher{callback: func(q string, limit int) ([]byte, error) {
		return []byte(`{}`), nil
	}}
	h := NewServer(fs, 1)
	if code, _ := get(t, h, "/get"); code != http.StatusBadRequest {
		t.Fatalf("missing id code = %d, want 400", code)
	}
	code, body := get(t, h, "/get?id=leaf-1&body=1")
	if code != http.StatusOK {
		t.Fatalf("get code = %d, want 200 body=%s", code, body)
	}
	if !strings.Contains(string(body), "leaf-1") {
		t.Fatalf("get body %s missing id", body)
	}
}

func TestStatsAuditIngest(t *testing.T) {
	h := NewServer(&fakeSearcher{}, 1)
	for _, path := range []string{"/stats", "/audit", "/ingest"} {
		code, body := get(t, h, path)
		if code != http.StatusOK {
			t.Fatalf("%s code = %d, want 200 (%s)", path, code, body)
		}
		if !json.Valid(body) {
			t.Fatalf("%s body not json: %s", path, body)
		}
	}
}

func TestHTTPPackageDoesNotExecPython(t *testing.T) {
	raw, err := os.ReadFile("server.go")
	if err != nil {
		t.Fatal(err)
	}
	lower := strings.ToLower(string(raw))
	if strings.Contains(lower, "python3") || strings.Contains(lower, "bin/kb/search") {
		t.Fatal("httpapi must not exec Python or bin/kb/search")
	}
}

func TestDefaultSearchCmdIsBrainNotPython(t *testing.T) {
	t.Setenv("KB_SEARCH_CMD", "")
	cmd := defaultSearchCmd("/repo")
	if strings.Contains(strings.ToLower(cmd), "python") {
		t.Fatalf("search path still python: %s", cmd)
	}
	if !strings.Contains(cmd, "brain") {
		t.Fatalf("search path must be the Go brain binary, got %s", cmd)
	}
}

func TestSearchTimeout(t *testing.T) {
	fs := &fakeSearcher{delay: time.Second}
	h := NewServer(fs, 1)
	ctx, cancel := context.WithTimeout(context.Background(), 30*time.Millisecond)
	defer cancel()
	req := httptest.NewRequest(http.MethodGet, "/search?q=slow", nil).WithContext(ctx)
	rec := httptest.NewRecorder()

	done := make(chan struct{})
	go func() {
		h.ServeHTTP(rec, req)
		close(done)
	}()

	select {
	case <-done:
		// ServeHTTP returned; body should be an error json (we don't require a
		// specific code for the pathological ctx-cancel timing, only that it
		// does not hang forever).
		return
	case <-time.After(500 * time.Millisecond):
		t.Fatal("request hung after context cancellation")
	}
}